Ricky Rosario is el Rey full of Awesome.

Jul 29

rlr commented on pcraciunoiu/kitsune 5:00pm

Comment in ba45d95:

works great and tests pass! r+

rlr created gist: 499194 4:46pm

function getOS() { var os = [ ['Windows 3.11', /Win16/i],

rlr commented on jsocol/kitsune 2:52pm

Comment in b9f5c10:

WFM, r+

rlr pushed to 573820-aaq at rlr/kitsune 2:22pm

pcraciunoiu committed 978a7fe

[573820] Auto-reload page when login/registration iframe succeeds.
rlr committed e892c17

Showing the iframe modal to anonymous users
rlr committed 24584ee

Added confirmation step to AAQ
erikrose committed afaac7a

[581108, 581584] Implement auto-tagging based on product, category, OS, and FF version. Drop "Intel" and "PPC" from Mac OS names.

* Tags are added for full and tenths-place variants (e.g., 4.0.1 and 4.0) of known Firefox versions.
* An OS will be auto-tagged if there exists a tag with its name (case insensitive). (I posit ease of administration outweighs risk of abuse.)
* Finished off questions_config based on Cww's etherpad.
* Show user agent string in System Details pop-up.
rlr committed 25aff61

Show 'Other reason' in flagged items moderation queue (bug 582357)
rlr committed c61cba4

Fix for disappearing question title after form validation errors (bug 581230)

rlr added pcraciunoiu to kitsune 1:46pm

kitsune is at rlr/kitsune

rlr pushed to development at jsocol/kitsune 11:42am

rlr committed 25aff61

Show 'Other reason' in flagged items moderation queue (bug 582357)

rlr pushed to development at jsocol/kitsune 11:33am

rlr committed c61cba4

Fix for disappearing question title after form validation errors (bug 581230)

rlr created branch 582357-show-other-reason at rlr/kitsune 11:03am

New branch is at rlr/kitsune/tree/582357-show-other-reason
Compare 582357-show-other-reason branch with development »

rlr deleted branch 582834-notifications at kitsune 10:42am

Deleted branch was at rlr/kitsune/tree/582834-notifications

rlr deleted branch 582887-system-info at kitsune 10:41am

Deleted branch was at rlr/kitsune/tree/582887-system-info

rlr deleted branch 581093-aaq-stub at kitsune 10:41am

Deleted branch was at rlr/kitsune/tree/581093-aaq-stub

rlr pushed to development at jsocol/kitsune 10:40am

rlr committed 9f2437b

Only guess system details if they aren't set [bug 582887]

rlr created branch 581230-title-disappears at rlr/kitsune 10:39am

New branch is at rlr/kitsune/tree/581230-title-disappears
Compare 581230-title-disappears branch with development »

rlr created branch 582887-system-info at rlr/kitsune 10:19am

New branch is at rlr/kitsune/tree/582887-system-info
Compare 582887-system-info branch with development »

@alexisc felicidades guey! 8:44am in reply to alexisc

Jul 28

rlr pushed to development at rlr/kitsune 10:38pm

rlr committed 415f5ca

Fix for bug 582834
pcraciunoiu committed 466b65a

Undo SkipTest for image upload since Hudson seems to have figured out JPEG encoding.
pcraciunoiu committed fbf87c4

[582775] Convert image to RGB before creating thumbnail.
jsocol committed 69c1b19

Skip the upload test until Hudson gets the library thing figured out.
rlr committed ddc0ec0

[bug 581093] Populating the AAQ form with real data.
pcraciunoiu committed fec585f

[578520] Move migration #22 to migrations/
jsocol committed 42a3f86

[bug 582743] Using item_title() methods to generate better feed titles.
pcraciunoiu committed 08f2586

[578520] Move thumbnail generation to a celery task. Create macros for attachments and add them to the reply and edit forms.
pcraciunoiu committed 8d9a069

[578520] Delete images and upload with no JS, thumbnail generation and ImageAttachments.
pcraciunoiu committed 5495c6e

[578520] Add preliminary support for uploading images and basic tests. Use ImageAttachments and generate thumbnails on upload.
jsocol committed 1b0b6ad

[bug 575724] Questions feeds now contain nice HTML instead of wiki markup.
rlr committed 4b05068

[bug 580835/bug 581048]
* Added event_type to notifications EventWatch model
* Implemented UI for receiving email notifications
endtwist committed 1c75371

Show proper number of posts and answered questions for each poster (bug 580777)
endtwist committed db79bcc

Align "Report this post" with other post options on questions forum (bug 582316)
jsocol committed f4b48b5

[bug 582312] Only show 'x of y' if y is > 0.
erikrose committed 2a88883

Fix the invalid and intermittently failing test_add_metadata.

Shorten my other test by passing multiple data to add_metadata, too.
erikrose committed 49fb48f

[569286] Implement question editing and "last edited by" readout.

Here's an overview:
* Reused most of EditQuestionForm for the New Question form.
* Refactored templates so new and edit share most of their code.
* Added `product` and `category` properties to Question so we don't need so many helper functions.
* Turned questions_config.products into SortedDicts to eliminate lookup code.

Caveats:
* We now never store a question's category if we don't store its product. (Will this be a problem?)
* Category and product are immutable. Doing otherwise would open a whole can of state-tracking and data-loss worms. And if you're changing products, isn't it logically a new question anyway?

Fixed some other bugs along the way:
* Made QuestionMetaData.question and .name unique_together.
* Store the product and category keys, not u"<django.functional.proxy>", etc., in the question metadata.
* Fixed an error in a field label string.

rlr pushed to development at jsocol/kitsune 10:38pm

rlr committed 415f5ca

Fix for bug 582834

rlr created branch 582834-notifications at rlr/kitsune 10:33pm

New branch is at rlr/kitsune/tree/582834-notifications
Compare 582834-notifications branch with development »

rlr commented on pcraciunoiu/kitsune 9:33pm

Comment in 8e2fb48:

fine with me, if you haven't merged yet!

rlr pushed to 581093-aaq-stub at rlr/kitsune 6:01pm

rlr committed bef0bc7

I think I have them all covered now

rlr created branch 581093-aaq-stub at rlr/kitsune 5:08pm

New branch is at rlr/kitsune/tree/581093-aaq-stub
Compare 581093-aaq-stub branch with development »

rlr deleted branch 580835-581048-email-ui at kitsune 3:53pm

Deleted branch was at rlr/kitsune/tree/580835-581048-email-ui

rlr deleted branch 580280-delete-answer at kitsune 3:53pm

Deleted branch was at rlr/kitsune/tree/580280-delete-answer

rlr pushed to development at jsocol/kitsune 3:31pm

rlr committed 4b05068

[bug 580835/bug 581048]
* Added event_type to notifications EventWatch model
* Implemented UI for receiving email notifications

rlr commented on rlr/kitsune 3:09pm

Comment on apps/notifications/__init__.py L7 in 99d501c:

The idea was I wanted to require an event_type for creating the watch. But I want to be able to destroy or check for any event_type.

@ErikRose just get the super awesome magical trackpad 2:11pm in reply to ErikRose

rlr pushed to 580835-581048-email-ui at rlr/kitsune 2:06pm

rlr committed 100ee46

And a test for unwatch

rlr pushed to 580835-581048-email-ui at rlr/kitsune 1:59pm

rlr committed 205b057

Added tests

rlr pushed to 580835-581048-email-ui at rlr/kitsune 1:27pm

rlr committed 99d501c

Now users can unwatch. Also, added watching badge.

rlr pushed to 580835-581048-email-ui at rlr/kitsune 11:26am

rlr committed 75851e7

Factored out common CSS styles for pop-ins

rlr pushed to 580835-581048-email-ui at rlr/kitsune 11:11am

rlr committed e8c0e31

Feedback incorporated. TODO: watching badge, unsubscribe form

rlr commented on pcraciunoiu/kitsune 9:34am

Comment in 899bdb5:

My computer is faster than jsocol's... nana na na.. :-P

rlr commented on pcraciunoiu/kitsune 9:31am

Comment in 899bdb5:

First I got (with FORCE_DB):

Ran 374 tests in 149.653s
FAILED (failures=1)

Then I got:

Ran 374 tests in 68.218s
OK

And then I got:

Ran 374 tests in 86.860s
FAILED (errors=3, failures=7)

rlr commented on rlr/kitsune 9:19am

Comment on media/css/questions.css L712 in 61ab5fd:

true that. lots of common rules I should factor them out into a class.

rlr commented on rlr/kitsune 9:18am

Comment on apps/questions/views.py L430 in 61ab5fd:

kewl

rlr commented on rlr/kitsune 9:18am

Comment on apps/questions/templates/questions/includes/question_vote_thanks.html L14 in 61ab5fd:

That should simplify a few things :)

rlr commented on rlr/kitsune 9:17am

Comment on apps/questions/templates/questions/includes/question_vote_thanks.html L5 in 61ab5fd:

ftw!

Jul 27

rlr pushed to 580835-581048-email-ui at rlr/kitsune 10:48pm

rlr committed 8971017

Almost done. Need to go over after some rest to verify and test.

rlr pushed to 580835-581048-email-ui at rlr/kitsune 8:54pm

rlr committed 4b022ec

Added solution notification

rlr pushed to 580835-581048-email-ui at rlr/kitsune 6:40pm

rlr committed 61ab5fd

wip

rlr commented on rlr/kitsune 6:38pm

Comment on apps/access/helpers.py L18 in 1cd95d6:

Yes, it landed. But I don' think there is a redundant check. The decorator calls has_perm_or_owns from init.py, which doesn't do this check?

rlr commented on rlr/kitsune 4:02pm

Comment in c4603b0:

I probably need to add a migration to update the rows already in the table to have the right event_type.

rlr pushed to 580835-581048-email-ui at rlr/kitsune 3:55pm

rlr committed c4603b0

Added event_type to notifications EventWatch model to support watching replied vs solved in questions app.

rlr created branch 580835-581048-email-ui at rlr/kitsune 3:54pm

New branch is at rlr/kitsune/tree/580835-581048-email-ui
Compare 580835-581048-email-ui branch with development »

rlr deleted branch 569288-fix-edit-answer at kitsune 2:11pm

Deleted branch was at rlr/kitsune/tree/569288-fix-edit-answer

rlr pushed to development at rlr/kitsune 2:11pm

rlr committed 5d5e93d

Fixed and added test: answer creator can edit the answer (bug 569288)
rlr committed 917ad7d

Don't assume that CACHE_PREFIX is defined in settings
rlr committed 8af5336

Implemented object flagging app, flagit, for 'Report this post'
functionality (bug 573068)

rlr pushed to development at jsocol/kitsune 2:11pm

rlr committed 5d5e93d

Fixed and added test: answer creator can edit the answer (bug 569288)

rlr deleted branch fix-hudson at kitsune 2:01pm

Deleted branch was at rlr/kitsune/tree/fix-hudson

rlr pushed to development at jsocol/kitsune 12:11pm

rlr committed 917ad7d

Don't assume that CACHE_PREFIX is defined in settings

rlr pushed to 569288-fix-edit-answer at rlr/kitsune 12:10pm

rlr committed 1cd95d6

Use the existing permissions helper and decorator.

Latest Blog Post

Joined the Mozilla Web Team

Latest Activity

About

Elsewhere

Categories

Recent Posts

Popular Posts

Blog Archive